[8u] RFR for JDK-8152438: Threads may do significant work out of the non-shared overflow buffer

Thomas Schatzl thomas.schatzl at oracle.com
Tue Aug 30 09:28:31 UTC 2016


Hi,

On Tue, 2016-08-30 at 01:05 -0700, Shafi Ahmad wrote:
> Hi,
> 
> Please review the backport of bug: "JDK-8152438: Threads may do
> significant work out of the non-shared overflow buffer" to jdk8u.
> 
> Please note that the backport is not clean. The import conflict is
> due to:
>   1. File taskqueue.inline.hpp doesn't exist in jdk8 so I have added
> code change done in this file to taskqueue.hpp. 
>   2. File name path change.
> 
> Webrev link: http://cr.openjdk.java.net/~shshahma/8152438/webrev.00/
> Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8152438
> Original patch pushed to jdk9: http://hg.openjdk.java.net/jdk9/jdk9/h
> otspot/rev/07109ac130cd
> 
> Testing: jprt and running jtreg [not completed].

  looks good.

Maybe you want the same spacing for the changes in the declaration of
the OverflowTaskQueue class (no newline between
OverflowTaskQueue::push() and OverflowTaskQueue::try_push()) as in the
jdk9 change.

I leave it up to you. I would not need a re-review for removing the
extra newline.

Thanks,
  Thomas



More information about the hotspot-dev mailing list