RFR: 8151600: Syntax for -Xlog complicates shell scripts

Coleen Phillimore coleen.phillimore at oracle.com
Tue Aug 30 14:48:54 UTC 2016


Honestly, I think I can live with "*" rather than "+" and definitely 
better than "%" (the latter seems a bit meaningless).

Coleen

On 8/30/16 10:04 AM, Robbin Ehn wrote:
> Hi Dmitry,
>
> On 08/30/2016 03:56 PM, Dmitry Samersoff wrote:
>> Robbin,
>>
>> As far as I understand + is used as a delimiter
>> e.g. -Xlog:class+load
>>
>> It might be better to use % for wildcard.
>
> Yes it might, I thought trailing plus was best.
>
> E.g.
> "-Xlog:class+load*" would in this case be "-Xlog:class+load+"
>
> But if people prefer e.g. "-Xlog:class+load%" then we can go with that.
>
> Thanks for input!
>
> /Robbin
>
>>
>> -Dmitry
>>
>> On 2016-08-30 15:29, Robbin Ehn wrote:
>>> Hi all,
>>>
>>> The current syntax for -Xlog uses '*' for wildcard matching of tags.
>>> In shell scripts where * is unintended expanded causes problems.
>>> This patch adds the possibility to use trailing '+' instead.
>>>
>>> E.g.
>>> "-Xlog:gc+" is thus equivalent to "-Xlog:gc*"
>>>
>>> Tested with modified gtest test.
>>>
>>> Webrev: http://cr.openjdk.java.net/~rehn/8151600/hotspot.01/webrev/
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8151600
>>>
>>> Thanks!
>>>
>>> /Robbin
>>
>>



More information about the hotspot-dev mailing list