RFR(s): 8169206: TemplateInterpreter::_continuation_entry is never referenced

David Holmes david.holmes at oracle.com
Fri Dec 2 01:29:36 UTC 2016


Looks good.

Thanks,
David

On 2/12/2016 6:21 AM, Max Ockner wrote:
> I have removed the
> TemplateInterpreterGenerator::generate_continuation_for() methods for
> each platform.
> New webrev: http://cr.openjdk.java.net/~mockner/8169206.02/
>
> Thanks,
> Max
>
> On 11/30/2016 10:09 PM, Coleen Phillimore wrote:
>>
>> Hi Max,
>>
>> You didn't remove the platform specific
>> TemplateInterpreterGenerator::generate_continuation_for() methods.
>>
>> I think from ancient history, these used to be used for reexecuting
>> the bytecode after rewriting to the fast version from within
>> InterpreterRuntime.  That code's been long dead!
>>
>> Thanks - this will be a good cleanup for jdk10.
>> Coleen
>>
>> On 11/30/16 2:57 PM, Max Ockner wrote:
>>> Hello everyone!
>>>
>>> Please review this small fix which removes some dead code from the
>>> interpreter. TemplateInterpreter::_continuation_entry table and its
>>> accessor are never called from anywhere else.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8169206
>>> Webrev: http://cr.openjdk.java.net/~mockner/8169206.01/
>>>
>>> Tested with java -version.
>>>
>>> Thanks,
>>> Max
>>>
>>>
>>>
>>>
>>
>


More information about the hotspot-dev mailing list