RFR(S) : 8078450 : Implement consistent process for quarantine of tests

Igor Ignatyev igor.ignatyev at oracle.com
Sat Dec 3 10:15:38 UTC 2016


Hi Serguei,

thank you for reviewing this.

> +# convert list of directories to *dos* paths What does "dos" mean here?
I’ve copied/pasted that part from jdk/test/Makefile[1], so it will be easy to consolidate them in future. I assume _dos_ here means disk operation system, DOS. 

[1] http://hg.openjdk.java.net/jdk9/dev/jdk/file/ed6586330575/test/Makefile#l281

Thanks,
— Igor

> On Dec 3, 2016, at 3:57 AM, serguei.spitsyn at oracle.com wrote:
> 
> Hi Igor,
> 
> It looks good to me.
> Thank you for taking care about this.
> 
> One minor question on the comment:
> 
> http://cr.openjdk.java.net/~iignatyev/8078450/webrev.00/test/Makefile.udiff.html 
> 
> +# convert list of directories to *dos* paths What does "dos" mean here?
> 
> 
> Thanks,
> Serguei
> 
> 
> On 12/2/16 11:27, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8078450/webrev.00/
>>> 115 lines changed: 97 ins; 17 del; 1 mod;
>> Hi all,
>> 
>> could you please review this small changeset which introduces ProblemList for quarantining hotspot test and adds all currently quarantined tests to it?
>> 
>> a bit of background:
>> there are two cases when one wants to remove a test from test execution:
>>  - a test sporadically fails, but there is still a value in running this test, e.g. it can fail in some other way and reveal another problem within the product. we want to run such tests, but we don’t want to have noise from these tests. to get both, we are going to _quarantine_ these tests and run them separately.
>>  - a test always fails or can break other tests or host. running such tests makes more harm than good, so they should be _excluded_ from test execution completely.
>> jtreg provides two exclusion mechanisms: @ignore tag and ProblemList. ProblemList gives a possibility to remove a test from execution on a specific OS, arch, and since the expectation is to have more quarantined tests than excluded, it was decided to use ProblemList to quarantine and @ignore to exclude, another reason is to have consistent process for hotspot and jdk tests.
>> 
>> in two words, @ignore to exclude, ProblemList to quarantine.
>> 
>> webrev: http://cr.openjdk.java.net/~iignatyev/8078450/webrev.00/
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8078450
>> 
>> Thanks,
>> — Igor
> 



More information about the hotspot-dev mailing list