RFR: 8168503 JEP 297: Unified arm32/arm64 Port

Coleen Phillimore coleen.phillimore at oracle.com
Mon Dec 5 16:12:31 UTC 2016


The interpreter and runtime parts of this change look good to me, and I 
spot checked the arm code.
Coleen


On 12/5/16 10:23 AM, Bob Vandette wrote:
>> On Dec 2, 2016, at 8:04 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>
>> hi Bob,
>>
>> I would suggest to have separate webrevs for different repositories because different groups should look on them.
> There are only 3 non hotspot files and they are on top.  Forwarding to build-dev for their review.
>
>> For example, top repository and makefiles changes should be also reviewed on build-dev at openjdk.java.net
>>
>> Why do you need cahnges in SA libproc.h?
> The cross compilation toolchains we use do not define user_regs_struct or user_pt_regs.
>
> I just looked again and there is a definition of struct user_regs in user.h.  I might be able to change the code to:
>
> #if defined(arm) || defined(arm64)
> #define user_regs_struct user_regs
> #endif
>
> This change would result  in the exact same declaration based on the number of registers
> derived from the structure in user.h.
>
> Bob.
>
>
>> I saw Hotspot changes before and I think they are fine (did not dive deep).
>>
>> Thanks,
>> Vladimir
>>
>> On 12/2/16 12:28 PM, Bob Vandette wrote:
>>> Please review the proposed changes to be integrated under JEP 297.
>>>
>>> Summary:
>>>
>>> This JEP adds arm32 and arm64 Linux platform support to OpenJDK for JDK 9.
>>>
>>> This changeset also removes the support for the pregenerated interpreter since
>>> this is no longer supported.
>>>
>>> The addition of arm64 does not replace the existing aarch64 port.  A new configure
>>> option (-with-cpu-port=) allows for the selection of the existing aarch64 versus the
>>> 64-bit arm64 support being added via this JEP.  Please refer to the JEP for more details.
>>>
>>> JEP 297:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8168503
>>>
>>> Webrev:
>>>
>>> http://cr.openjdk.java.net/~bobv/8168503
>>>
>>>
>>> Note:
>>>
>>> A complete build-able forest containing these changes is located here: http://hg.openjdk.java.net/aarch32-port/jdk9-arm3264
>>>
>>> Thanks,
>>> Bob Vandette
>>>



More information about the hotspot-dev mailing list