RFR(S): 8170767: Zero fastdebug build triggers assertion

Coleen Phillimore coleen.phillimore at oracle.com
Tue Dec 13 16:08:54 UTC 2016


Severin,  I'm waiting for hs to open and I'll push your change.
Coleen

On 12/13/16 5:50 AM, Jesper Wilhelmsson wrote:
> This is a change in shared VM code. It should go through jprt.
>
> (Please do not interpret this mail as an approval to push. jdk9/hs is 
> still closed.)
> /Jesper
>
> Den 13/12/16 kl. 10:38, skrev Severin Gehwolf:
>> On Wed, 2016-12-07 at 22:58 -0500, Coleen Phillimore wrote:
>>> This looks good and I can sponsor this for you.  I haven't built 
>>> Zero in
>>> a while.
>>
>> Hi Coleen,
>>
>> Is it OK for me to push this change? I'm not entirely clear on which
>> changes need to go through JPRT. In theory I should be able to push
>> this change with my new committer powers ;-)
>>
>> Thanks,
>> Severin
>>
>>> On 12/7/16 7:57 AM, Severin Gehwolf wrote:
>>>>
>>>> Hi,
>>>>
>>>> Could somebody please review this Zero only change? The problem was
>>>> there before, but only the fix for JDK-8169711 brought it to the
>>>> surface. The returned method kind for
>>>> java_lang_math_fmaD/java_lang_math_fmaF is no longer guarded by UseFMA
>>>> in abstractInterpreter.cpp
>>>>
>>>> The fix is to generate stub entries for
>>>> java_lang_math_fmaD/java_lang_math_fmaF which were missing. Thoughts?
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8170767
>>>> webrev: 
>>>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8170767/webrev.01/
>>>>
>>>> Thanks,
>>>> Severin
>>>
>>



More information about the hotspot-dev mailing list