RFR(XS): 8171097: Convert TestReservedSpace_test to Gtest

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Tue Dec 27 15:32:10 UTC 2016


Igor,

Thank you for review!

Regards, Kirill

On 27.12.2016 17:49, igor.ignatyev at oracle.com wrote:
> Hi Kirill,
>
> Looks good to me.
>
> -- II
>
> ----- Reply message -----
> From: "Kirill Zhaldybin" <kirill.zhaldybin at oracle.com>
> To: "hotspot-runtime-dev at openjdk.java.net" 
> <hotspot-runtime-dev at openjdk.java.net>, "hotspot-dev developers" 
> <hotspot-dev at openjdk.java.net>
> Subject: RFR(XS): 8171097: Convert TestReservedSpace_test to Gtest
> Date: Tue, Dec 27, 2016 17:41
>
> After getting offline comments I updated webrev:
> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8171097/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ekzhaldyb/webrevs/JDK-8171097/webrev.01/>
>
> Changes:
> 1. Deleted "return;" which was not needed
> 2. Changed two ASSERTs to EXPECTs
>
> Thank you.
>
> Regards, KIrill
>
> On 12.12.2016 19:31, Kirill Zhaldybin wrote:
> > Dear all,
> >
> > Could you please review this fix for 8171097?
> >
> > WebRev:
> >http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8171097/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ekzhaldyb/webrevs/JDK-8171097/webrev.00/>
> > CR:https://bugs.openjdk.java.net/browse/JDK-8171097
> >
> > Thank you.
> >
> > Regards, Kirill
>



More information about the hotspot-dev mailing list