[9] RFR (S): 8149141: Optimized build is broken

[Kim Barrett]

> On Feb 5, 2016, at 12:37 PM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~vlivanov/8149141/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8149141
> 
> !defined(PRODUCT) & ASSERT confusion.
> 
> Best regards,
> Vladimir Ivanov
> 
> PS: I'm surprised that unit tests are full of asserts, but guarded by !defined(PRODUCT). Any reason to keep the tests in optimized build?

Some of the tests I’ve written use guarantee for that very reason.  But apparently not all,
as one of the ones being fixed by this change is one of mine.  Oops.