RFR: 8149591 - Prepare hotspot for GTest
Jesper Wilhelmsson
jesper.wilhelmsson at oracle.com
Wed Feb 10 20:40:38 UTC 2016
Thanks George!
/Jesper
Den 10/2/16 kl. 21:23, skrev George Triantafillou:
> Hi Jesper,
>
> Your changes look good.
>
> -George
>
> On 2/10/2016 2:47 PM, Jesper Wilhelmsson wrote:
>> Hi,
>>
>> Please review this change to prepare the Hotspot code for the Google unit test
>> framework. From the RFE:
>>
>> A few changes are needed in the hotspot code to start using the Google Test
>> framework.
>>
>> 1. The new() operator as defined in allocation.cpp can not be used together
>> with GTest. This needs to be moved to a separate file so that we can avoid
>> compiling it when building the GTest enabled JVM.
>>
>> 2. In management.cpp there is a local variable called err_msg. This variable
>> is shadowing a global variable in debug.hpp. In the GTest work the global
>> err_msg variable is used in the vmassert macro and this creates a conflict
>> with the local variable in management.cpp.
>>
>> 3. If SuppressFatalErrorMessage is set ALL error messages should be
>> suppressed, even the ones in error_is_suppressed() in debug.cpp.
>>
>> This is what is done by this change.
>>
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8149591
>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8149591/webrev.00/index.html
>>
>> Thanks,
>> /Jesper
>
More information about the hotspot-dev
mailing list