(XS) RFR: 8149427: Remove .class files from the hotspot repo .hgignore file
David Holmes
david.holmes at oracle.com
Mon Feb 15 03:13:46 UTC 2016
Is Michael away? If I don't hear anything to the contrary in the next 24
hours I will push this change.
Thanks,
David
On 10/02/2016 8:54 AM, Christian Thalinger wrote:
> Ask Michael.
>
>> On Feb 8, 2016, at 9:04 PM, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
>>
>>
>> Looks good.It would of course be great to understand why it was added to start with, but even so I don't think it should be there (and we should instead fix whatever caused it to be added).
>>
>> Cheers,
>> Mikael
>>
>> On 2016-02-08 21:48, David Holmes wrote:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8149427
>>>
>>> webrev: http://cr.openjdk.java.net/~dholmes/8149427/webrev/
>>>
>>> JDK-6900757 added the following to .hgignore:
>>>
>>> +\.class$
>>>
>>> but it is unclear why this was done. This setting can cause problems when jtreg testing leaves class files in unexpected places, and -stree JPRT submissions then fail testing in strange ways. "hg status" doesn't show these errant files because of the entry in .hgignore.
>>>
>>> I propose to remove the entry from the .hgignore file.
>>>
>>> Thanks,
>>> David
>>>
>>>
>>> patch:
>>>
>>> --- old/./.hgignore 2016-02-09 00:43:28.786882859 -0500
>>> +++ new/./.hgignore 2016-02-09 00:43:27.254796576 -0500
>>> @@ -10,7 +10,6 @@
>>> .igv.log
>>> ^.hgtip
>>> .DS_Store
>>> -\.class$
>>> ^\.mx.jvmci/env
>>> ^\.mx.jvmci/.*\.pyc
>>> ^\.mx.jvmci/eclipse-launches/.*
>>>
>>> ---
>>>
>>
>
More information about the hotspot-dev
mailing list