RFR(s): 8148219: Add decorator hostname to UL

[David Holmes]

Hi Robbin,

A couple of minor comments ...

On 12/02/2016 10:16 PM, Robbin Ehn wrote:
> Hi, please review.
>
> This adds a new decorator for hostname to UL, with minor changes to
> os::get_host_name and UL init.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8148219
> Webrev: http://cr.openjdk.java.net/~mlarsson/rehn/8148219/

src/os/windows/vm/os_windows.cpp

   #ifdef ASSERT
     char buffer[1024];
+   const char* hostname = "N/A";
     st->print("HostName: ");
+ #ifndef PRODUCT

If ASSERT is true then PRODUCT should never be true - we don't do 
PRODUCT builds with asserts enabled.

That aside I don't see the point of the changes you made in this 
function. ??

---

src/share/vm/runtime/os.hpp

There's no need to move the get_host_name declaration or note that it is 
used by UL. Just get rid of the PRODUCT_RETURN in the existing code.

---

Please update all copyright years as needed. Where there is a single 
year like "2015, " it becomes "2015, 2016, ".

Thanks,
David
-----


> Manual tested and verified no change to hs_err_pid (uses
> os::get_host_name when fastdebug build) and that UL prints hostname.
>
> Thanks!
>
> /Robbin