RFR(S): 8143245: Zero build requires disabled warnings

David Holmes david.holmes at oracle.com
Wed Feb 17 08:38:36 UTC 2016


Hi Severin,

On 17/02/2016 3:47 AM, Severin Gehwolf wrote:
> Hi,
>
> Could somebody please review and sponsor this Zero-only change. The
> hotspot build for Zero had some compiler warnings disabled for no good
> reason. I've fixed the code so the silencing isn't necessary any more.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8143245
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8143245/webrev.01/
>
> Thoughts?

This seems okay to me. One minor nit in os_linux_zero.cpp, SpinPause has 
an indent of 4 instead of 2. :)

Is there a specific Zero reviewer you want to approve this?

David
-----

> Thanks,
> Severin
>


More information about the hotspot-dev mailing list