RFR(S): 8143245: Zero build requires disabled warnings

Severin Gehwolf sgehwolf at redhat.com
Thu Feb 18 09:01:16 UTC 2016


On Wed, 2016-02-17 at 14:39 -0500, Coleen Phillimore wrote:
> Hi, this looks good.  I'll test it out and sponsor it.
> Thanks Severin.
> Coleen

Thanks David and Coleen!

Cheers,
Severin

> On 2/17/16 3:38 AM, David Holmes wrote:
> > Hi Severin,
> > 
> > On 17/02/2016 3:47 AM, Severin Gehwolf wrote:
> > > Hi,
> > > 
> > > Could somebody please review and sponsor this Zero-only change. The
> > > hotspot build for Zero had some compiler warnings disabled for no good
> > > reason. I've fixed the code so the silencing isn't necessary any more.
> > > 
> > > Bug: https://bugs.openjdk.java.net/browse/JDK-8143245
> > > webrev: 
> > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8143245/webrev.01/
> > > 
> > > Thoughts?
> > 
> > This seems okay to me. One minor nit in os_linux_zero.cpp, SpinPause 
> > has an indent of 4 instead of 2. :)
> > 
> > Is there a specific Zero reviewer you want to approve this?
> > 
> > David
> > -----
> > 
> > > Thanks,
> > > Severin
> > > 
> 



More information about the hotspot-dev mailing list