PING: 8150045: AArch64: arraycopy causes segfaults in SATB during garbage collection

[Andrew Haley]

Can I have an official review of this, please?  Vladimir or Roland, please
have a quick look.

Maybe it's time to make Andrew Dinn a JDK 9 reviewer.

Andrew.


On 02/18/2016 03:47 PM, Andrew Dinn wrote:
> On 17/02/16 14:25, Andrew Haley wrote:
>> Sorry, I forgot to say this is AArch64-specific.
>>
>> On 02/17/2016 02:22 PM, Andrew Haley wrote:
>>> This is a bug due to the abuse of default arguments in C++.  I, ah,
>>> forgot to pass dest_uninitialized to the OOP arraycopy routines, so we
>>> always scan the destination array, even though it contains garbage.
>>>
>>> I also took the opportunity to do a little tidying-up.
>>>
>>> http://cr.openjdk.java.net/~aph/8150045/
> 
> This looks fine, including the tidying up. Reviewed as AArch64-only change.
> 
> regards,
> 
> 
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in UK and Wales under Company Registration No. 3798903
> Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul
> Argiry (US)
>