RFR(XS): 8149973: Optimize object alignment check in debug builds.
Dmitry Dmitriev
dmitry.dmitriev at oracle.com
Wed Feb 24 11:37:47 UTC 2016
Hi David,
Thank you for the review!
Dmitry
On 24.02.2016 14:28, David Holmes wrote:
> Hi Dmitry,
>
> On 24/02/2016 8:42 PM, Dmitry Dmitriev wrote:
>> Hello,
>>
>> Please, review small optimization to the object alignment check in the
>> debug builds. In this fix I replace division by MinObjAlignmentInBytes
>> to bitwise AND operation with MinObjAlignmentInBytesMask, because
>> MinObjAlignmentInBytes is a power of two. Suggested construction already
>> used in MacroAssembler, e.g.
>> hotspot/src/cpu/x86/vm/c1_MacroAssembler_x86.cpp).
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8149973
>> webrev.00: http://cr.openjdk.java.net/~ddmitriev/8149973/webrev.00/
>> <http://cr.openjdk.java.net/%7Eddmitriev/8149973/webrev.00/>
>> Testing: jprt, hotspot_all
>
> Seems functionally correct - and as you say mirrors existing code.
>
> Cheers,
> David
>
>> Thanks,
>> Dmitry
More information about the hotspot-dev
mailing list