RFR: 8150617: nth_bit and friends are broken

Stefan Karlsson stefan.karlsson at oracle.com
Thu Feb 25 14:59:48 UTC 2016


Hi Aleksey,

On 2016-02-25 13:39, Aleksey Shipilev wrote:
> On 02/25/2016 03:22 PM, Stefan Karlsson wrote:
>> Please review this patch to fix the nth_bit, right_n_bits, and
>> left_n_bits macros.
>>   http://cr.openjdk.java.net/~stefank/8150617/webrev.00
> Oh snap. Are there actual usages in VM that break?

A cursory glance at the code didn't show any existing problems. I saw 
this while I was looking at a problem where we compared singed and 
unsigned integers in nth_bit.
>
> The patch looks good to me.

Thanks,
StefanK

>
> Thanks,
> -Aleksey
>



More information about the hotspot-dev mailing list