RFR (S): JDK-8066599: Add methods to check VM mode to c.o.j.t.Platform

[Filipp Zhinkin]

Igor,

So, do you want me to include any other changes for this CR?

Regards,
Filipp.

On Wed, Jan 6, 2016 at 4:00 PM, Filipp Zhinkin <filipp.zhinkin at gmail.com> wrote:
> Hi Igor,
>
> here are RFEs for tests relocation and ClassFileInstaller relocation:
> https://bugs.openjdk.java.net/browse/JDK-8146549
> https://bugs.openjdk.java.net/browse/JDK-8146550
>
> Thanks,
> Filipp.
>
> On Sat, Jan 2, 2016 at 2:59 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>> Hi Filipp,
>>
>> there is no options to make ‘@library /test/lib’ works. there is ‘external.lib.roots’ property in TEST.ROOT files, which adds additional root for @library. I noticed that there is no /test/lib-test isn’t a part of any test-suites, hence moving test to test/lib-test implies extra work in infra. given that I think it’ll be better to do it lately and separately from 8066599. please file an RFE for that.
>>
>> on 2nd question, I think it makes sense to move ClassFileInstaller to jdk.test.lib and annotate ClassFileInstaller in both jdk/test/lib/testlibrary/ and hotspot/test/testlibrary/ w/ @Deprectate. and I also think it’d be better to do it separately.
>>
>> Thanks,
>> Igor
>>
>>> On Dec 25, 2015, at 12:41 PM, Filipp Zhinkin <filipp.zhinkin at gmail.com> wrote:
>>>
>>> Hi Igor,
>>>
>>> thanks for looking at this change.
>>>
>>> On Thu, Dec 24, 2015 at 9:24 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>>> Hi Filipp,
>>>>
>>>> could you please move TestMutuallyExclusivePlatformPredicates and TestPlatformIsTieredSupported from hotspot/testlibrary_tests/ to test/lib-test and update it according to your changes? please note that we started to use packages in our tests.
>>>
>>> Sure, I'll move it.
>>>
>>> Do I need to pass any specific options to jtreg to make '@library
>>> /test/lib' work?
>>> At the moment jtreg can't locate it unless I specify
>>> '/../../test/lib/share/classes'.
>>>
>>> Does it make sense to also move ClassFileInstaller to jdk.test.lib?
>>>
>>>
>>> Thanks,
>>> Filipp.
>>>
>>>>
>>>> otherwise looks good to me.
>>>>
>>>> Thanks,
>>>> — Igor
>>>>
>>>>> On Dec 22, 2015, at 10:36 AM, Filipp Zhinkin <filipp.zhinkin at gmail.com> wrote:
>>>>>
>>>>> Hi all,
>>>>>
>>>>> please review a small change that adds VM mode checking methods to
>>>>> jdk.test.lib.Platform.
>>>>> I didn't touch Platform class from hotspot/test/testlibrary, because
>>>>> it is already deprecated and at some point of time all hs tests will
>>>>> be updated to use j.t.l.Platform instead.
>>>>> Update of hs tests that use own logic to check VM mode is tracked by
>>>>> JDK-8145848 [1].
>>>>>
>>>>> Webrev: http://cr.openjdk.java.net/~fzhinkin/8066599/webrev.00/
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8066599
>>>>> Testing: on local machine with different VM modes.
>>>>>
>>>>> Regards,
>>>>> Filipp.
>>>>>
>>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8145848
>>>>
>>