RFR: 8146994: Move internal vm tests to a separate file

[Stefan Karlsson]

Looks good.

Thanks,
StefanK

On 2016-01-14 12:41, Erik Helin wrote:
> On 2016-01-14, Stefan Karlsson wrote:
>> Hi Erik,
>>
>> Thanks for moving the tests!
> Thanks for reviewing!
>
>> Could you make sure you order the includes with the #if sections at the end.
>> It's also important that you include utilites/macros.hpp before the #if
>> sections, otherwise they will evaluate to false although the defines are set
>> to true in that file.
>>
>> So, change:
>>
>>    29 #include "classfile/altHashing.hpp"
>>    30 #include "gc/shared/collectedHeap.hpp"
>>    31 #include "gc/shared/gcTimer.hpp"
>>    32 #if INCLUDE_ALL_GCS
>>    33 #include "gc/g1/heapRegionRemSet.hpp"
>>    34 #endif
>>    35 #include "compiler/directivesParser.hpp"
>>    36 #include "memory/guardedMemory.hpp"
>>    37 #include "utilities/json.hpp"
>>    38 #include "utilities/ostream.hpp"
>>    39 #include "utilities/internalVMTests.hpp"
>>    40 #include "utilities/quickSort.hpp"
>>    41 #if INCLUDE_VM_STRUCTS
>>    42 #include "runtime/vmStructs.hpp"
>>    43 #endif
>>
>> to
>>
>>    #include "classfile/altHashing.hpp"
>>    #include "compiler/directivesParser.hpp"
>>    #include "gc/shared/collectedHeap.hpp"
>>    #include "gc/shared/gcTimer.hpp"
>>    #include "memory/guardedMemory.hpp"
>>    #include "utilities/json.hpp"
>>    #include "utilities/macros.hpp"
>>    #include "utilities/ostream.hpp"
>>    #include "utilities/internalVMTests.hpp"
>>    #include "utilities/quickSort.hpp"
>>    #if INCLUDE_ALL_GCS
>>    #include "gc/g1/heapRegionRemSet.hpp"
>>    #endif
>>    #if INCLUDE_VM_STRUCTS
>>    #include "runtime/vmStructs.hpp"
>>    #endif
> Sure, new patches are available at:
> - full: http://cr.openjdk.java.net/~ehelin/8146994/01/
> - inc: http://cr.openjdk.java.net/~ehelin/8146994/01/inc/
>
> Thanks,
> Erik
>
>> Thanks,
>> StefanK
>>
>> On 2016-01-13 17:32, Erik Helin wrote:
>>> Hi all,
>>>
>>> this patch moves the internal vm tests (the ones executed via
>>> -XX:+ExecuteInternalVMTests) to new files:
>>> utilities/internalVMTests.{hpp,cpp}
>>>
>>> Please note that this patch only moves the tests (and adds includes
>>> required to build) on purpose, I have more patches coming that cleans up
>>> the internal vm tests a bit.
>>>
>>> Enhancement:
>>> https://bugs.openjdk.java.net/browse/JDK-8146994
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ehelin/8146994/00/
>>>
>>> Testing:
>>> - Running test locally
>>> - Running tests in JPRT
>>>
>>> Thanks,
>>> Erik