RFR: JDK-8160353: narrowing conversion error is occurred with GCC 6

Kim Barrett kim.barrett at oracle.com
Sun Jul 3 16:11:33 UTC 2016


> On Jul 3, 2016, at 10:56 AM, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
> 
> Hi Kim,
> 
> On 2016/07/03 1:02, Kim Barrett wrote:
>>> On Jul 2, 2016, at 8:53 AM, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
>>> 
>>> Hi Kim,
>>> 
>>>> So the proposed casts seem to me to be just papering over a deeper
>>>> problem. I suggest separating this into a different CR for later
>>>> cleanup, since it's not an immediate problem once the build problem is
>>>> fixed.
>>> 
>>> I removed change for type.hpp in new webrev:
>>> 
>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8160353/webrev.01/
>> 
>> This looks good.
>> 
>> I can sponsor, once there’s a second review.
> 
> Thanks!
> I'm waiting a second reviewer.
> 
> 
>>> If JDK-8156980 is resolved, this error will be gone.
>>> IMHO, it should be fixed.
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8160748
> 
> Thanks!
> I've posted a email about this:
>  http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-July/023611.html

I’m not going to review that, but I took a very brief look and:

---------------
src/share/vm/opto/opcodes.hpp
  30 enum Opcodes : uint {

This is not valid C++98 code.  It is using a C++11 feature.

---------------

My intent in separating was to allow JDK-8160748 to be dealt with later,
probably not in JDK 9 at all, since the implicit narrowing is not a problem
with C++98.





More information about the hotspot-dev mailing list