s390x port progress: patch queue for hotspot assembled.

Andrew Haley aph at redhat.com
Mon Jul 4 07:48:29 UTC 2016


On 04/07/16 08:35, David Holmes wrote:
>> An obvious solution to this problem would be to simply remove the
>> > os/arch parts from the corresponding filenames (they are encoded in
>> > the directory path anyway) and only use the correct include path for
>> > every platform while building (I think we already do that). E.g.
> I'm sure that was proposed originally but rejected for some reason ...
> 
> Need to do some archaeology :)

I would think it better to leave the filenames as they are but add
"assembler_cpu.hpp" to the target CPU directory.  And then
"assembler_cpu.hpp" includes, say, "assembler_aarch64.hpp".  That's a
much less intrusive change, and doesn't end up confusing any debugging
and searching tools.

Andrew.


More information about the hotspot-dev mailing list