Re: RFR(XS): 8160119: Utils.tryFindJvmPid sometimes find incorrect pid

[igor.ignatyev@oracle.com]

Boris,

Looks good to me.

Thanks
-- II

----- Reply message -----
From: "Boris Molodenkov" <boris.molodenkov at oracle.com>
To: "David Holmes" <david.holmes at oracle.com>, <hotspot-dev at openjdk.java.net>, "Igor Ignatyev" <igor.ignatyev at oracle.com>
Subject: RFR(XS): 8160119: Utils.tryFindJvmPid sometimes find incorrect pid
Date: Wed, Jul 6, 2016 19:06

Simplified regex according to Igor's comment.
"^([0-9]+)\\s.*(" + key + ").*$"  -> "^([0-9]+)\\s.*(" + key + ")"

Updated webrev:
http://cr.openjdk.java.net/~bmoloden/8160119/webrev.02/

Thanks,
Boris

On 01.07.2016 15:25, Boris Molodenkov wrote:
> Hi David,
>
> Thank you for comment.
> Copyright was updated. Typo was fixed.
>
> I updated webrev because want to have complete webrev for 8u backporting.
> http://cr.openjdk.java.net/~bmoloden/8160119/webrev.01
>
> Thanks,
> Boris
>
> On 01.07.2016 06:22, David Holmes wrote:
>> Hi Boris,
>>
>> On 1/07/2016 2:40 AM, Boris Molodenkov wrote:
>>> Hi All,
>>>
>>> Could you please review fix?
>>>
>>> Utils.tryFindJvmPid incorrectly determines process id from jcmd output
>>> if line which contains desired PID is just after line which ends with
>>> numbers.
>>> Fixed pattern.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8160119
>>> Webrev: http://cr.openjdk.java.net/~bmoloden/8160119/webrev.00
>>
>> I'm no regex expert but that revised pattern seems good to me - it 
>> constrains the pattern to a line at a time, with only starting digits 
>> allowed.
>>
>> Can you fix the typo in the comment preceding that line please - 
>> follwed.
>>
>> Also copyright year needs updating.
>>
>> No need for updated webrev.
>>
>> Thanks,
>> David
>>
>>> Thanks,
>>> Boris
>>>
>