RFR: JDK-8160350 cannot truss jdk9 [solaris]
Kim Barrett
kim.barrett at oracle.com
Wed Jul 6 18:41:16 UTC 2016
> On Jul 6, 2016, at 1:45 PM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
>
> On 7/6/16 8:30 AM, Coleen Phillimore wrote:
>>
>> I uploaded it here:
>>
>> http://cr.openjdk.java.net/~coleenp/JDK-8160350.02/index.html
>
> src/os/solaris/vm/os_solaris.cpp
> L1322: bool os::supports_vtime() { return true; }
> L1323: bool os::enable_vtime() { return false; }
> L1324: bool os::vtime_enabled() { return false; }
>
> Seems like supports_vtime() should return 'false'.
> If there is a reason that it shouldn't, then we
> need a comment.
>
> Thumbs up modulo changing the return of supports_vtime()
> or adding a comment. I don't need to see a new webrev.
I’m confused. Why would we want supports_vtime to return false?
More information about the hotspot-dev
mailing list