RFR: JDK-8160350 cannot truss jdk9 [solaris]
Alan Burlison
Alan.Burlison at oracle.com
Wed Jul 6 19:04:49 UTC 2016
On 06/07/2016 18:45, Daniel D. Daugherty wrote:
> src/os/solaris/vm/os_solaris.cpp
> L1322: bool os::supports_vtime() { return true; }
> L1323: bool os::enable_vtime() { return false; }
> L1324: bool os::vtime_enabled() { return false; }
>
> Seems like supports_vtime() should return 'false'.
> If there is a reason that it shouldn't, then we
> need a comment.
>
> Thumbs up modulo changing the return of supports_vtime()
> or adding a comment. I don't need to see a new webrev.
It's that way on all the other platforms, I simply made it the same on
Solaris as everywhere else. If I change it to return true on Solaris
then it will be different to everywhere else.
$ grep supports_vtime */*/*
aix/vm/os_aix.cpp:bool os::supports_vtime() { return true; }
bsd/vm/os_bsd.cpp:bool os::supports_vtime() { return true; }
linux/vm/os_linux.cpp:bool os::supports_vtime() { return true; }
solaris/vm/os_solaris.cpp:bool os::supports_vtime() { return true; }
windows/vm/os_windows.cpp:bool os::supports_vtime() { return true; }
--
Alan Burlison
--
More information about the hotspot-dev
mailing list