RFR: JDK-8160350 cannot truss jdk9 [solaris]

[Kim Barrett]

> On Jul 6, 2016, at 4:03 PM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> 
> On 7/6/16 12:41 PM, Kim Barrett wrote:
>>> On Jul 6, 2016, at 1:45 PM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
>>> 
>>> On 7/6/16 8:30 AM, Coleen Phillimore wrote:
>>>> I uploaded it here:
>>>> 
>>>> http://cr.openjdk.java.net/~coleenp/JDK-8160350.02/index.html
>>> src/os/solaris/vm/os_solaris.cpp
>>>    L1322: bool os::supports_vtime() { return true; }
>>>    L1323: bool os::enable_vtime() { return false; }
>>>    L1324: bool os::vtime_enabled() { return false; }
>>> 
>>>        Seems like supports_vtime() should return 'false'.
>>>        If there is a reason that it shouldn't, then we
>>>        need a comment.
>>> 
>>> Thumbs up modulo changing the return of supports_vtime()
>>> or adding a comment. I don't need to see a new webrev.
>> I’m confused.  Why would we want supports_vtime to return false?
> 
> Went back and looked again.
> 
> supports_vtime() should return true because os::elapsedVTime()
> still does something. enable_vtime() and vtime_enabled() return
> false because vtime support is always there and doesn't need to
> be enabled.
> 
> Slightly confusing (to me at least) and will be more clear when
> the follow on bug (https://bugs.openjdk.java.net/browse/JDK-8160887)
> is fixed.
> 
> Thumbs up as it is.

Looks good to me too.