RFR: 8160969: aarch64: CDS is broken after 8079507

[Jiangli Zhou]

> On Jul 7, 2016, at 10:32 AM, Andrew Haley <aph at redhat.com> wrote:
> 
> On 07/07/16 18:28, Jiangli Zhou wrote:
>> Hi Andrew,
>> 
>>> On Jul 7, 2016, at 7:05 AM, Andrew Haley <aph at redhat.com> wrote:
>>> 
>>> This one was reported by Ningsheng Jian at Linaro.
>>> 
>>> It's a simple error which happened when merging the x86 changes for CDS.
>>> 
>>> http://cr.openjdk.java.net/~aph/8160969/
>> 
>> 
>> Just curious, what failure did it run into with SharedStrings. JDK-8160969 <https://bugs.openjdk.java.net/browse/JDK-8160969> doesn’t give much detail.
> 
> #
> #  Internal Error (/home/aph/hs-comp/hotspot/src/cpu/aarch64/vm/macroAssembler_aarch64.cpp:2336), pid=17631, tid=17634
> #  assert(false) failed: DEBUG MESSAGE: patching the wrong bytecode
> 
> This is because it is trying to patch an unpatchable byte code.

Ok, thanks. The changes look okay to me. But someone who’s familiar with the aarch64 specific code should also review it.

Thanks,
Jiangli

> 
> Andrew.
>