RFR: 8161145: The min/max macros make hotspot tests fail to build with GCC 6

[Omair Majid]

Hi Kim,

Thanks for the review!

* Kim Barrett <kim.barrett at oracle.com> [2016-07-11 17:28]:
> > On Jul 11, 2016, at 2:45 PM, Omair Majid <omajid at redhat.com> wrote:
> > 
> > Hi,
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8161145
> > Webrev: http://cr.openjdk.java.net/~omajid/webrevs/8161145-gcc6-min-max-macros/00/
> 
> https://wiki.openjdk.java.net/display/HotSpot/StyleGuide
> All .cpp files include precompiled.hpp as the first include line.

Thanks for the pointer. I was not aware of this.

> I think a different approach is needed.  Perhaps don't provided the
> poisoned definitions at all.

That sounds like the best solution in the long term. But I am afraid to
remove it because it was probably added for a reason and I am not
familiar with the code.

> Or maybe we can use blue paint, e.g.
> 
>   #define min min
>   #define max max

Should I implement this approach? Or should I look into removing the
poisoned definitions?

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681