RFR: 8161208: Unable to run jtreg tests with MinimalVM
Dmitry Fazunenko
dmitry.fazunenko at oracle.com
Thu Jul 14 16:28:03 UTC 2016
Michail,
the fix looks good to me.
Before push, please fix:
135 if ( "minimal".equals(flavor))
136 return "false"; --> 135 if ("minimal".equals(flavor)) {
136 return "false"; 137 }
To meet the Java Coding Style.
Thanks,
Dima
On 14.07.2016 19:21, Michail Chernov wrote:
> Hi,
>
> Could I have a reviews for this change, please?
>
> https://bugs.openjdk.java.net/browse/JDK-8161208
> http://cr.openjdk.java.net/~mchernov/8161208/webrev.00/
> http://cr.openjdk.java.net/~mchernov/8161208/webrev.hotspot.00/
>
> This issue is started since this fix:
> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-June/018319.html
>
>
> This change fixes two issues:
> 1. Avoiding of java.management usage with minimal VM (JTreg was
> started with '-vmoptions:"-minimal"' and worked as expected).
> 2. Adding appropriate modules for proper VMProps execution on non-full
> JDK images (JTreg was tested with '-vmoptions:"-limitmods java.base"',
> java.compact1, java.compact2 and so on - JTreg is started and works as
> expected).
>
> Tested locally and via RBT/JPRT.
>
> Thanks
> Michail
More information about the hotspot-dev
mailing list