RFR: 8161208: Unable to run jtreg tests with MinimalVM

[David Holmes]

Hi Michail,

On 15/07/2016 2:21 AM, Michail Chernov wrote:
> Hi,
>
> Could I have a reviews for this change, please?
>
> https://bugs.openjdk.java.net/browse/JDK-8161208
> http://cr.openjdk.java.net/~mchernov/8161208/webrev.00/
> http://cr.openjdk.java.net/~mchernov/8161208/webrev.hotspot.00/
>
> This issue is started since this fix:
> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-June/018319.html

I think I would have objected to the form of that fix - VMProps was only 
looking at information available via system properties.

> This change fixes two issues:
> 1. Avoiding of java.management usage with minimal VM (JTreg was started
> with '-vmoptions:"-minimal"' and worked as expected).

Okay.

> 2. Adding appropriate modules for proper VMProps execution on non-full
> JDK images (JTreg was tested with '-vmoptions:"-limitmods java.base"',
> java.compact1, java.compact2 and so on - JTreg is started and works as
> expected).

Was that testing done with a full VM or the Minimal VM? On a full VM 
limited to compact1, compact2 or java.base, java.lang.management will 
not be present, but we will execute the query code in VMProps as it 
isn't the minimal VM.

Thanks,
David

> Tested locally and via RBT/JPRT.
>
> Thanks
> Michail