RFR(S): 8162727 - Testbug: additional requires properties can't be used for filtering server vm in jdk jtreg tests

[Dmitry Fazunenko]

Hi Dmitrij,

The change itself looks good.

One note: this change adds a little overhead (a very little) for running 
tests in jdk repository, but it's required only for VM specific tests 
stored in jdk. As alternative of this change I can suggest moving VM 
specific tests from the 'jdk' to 'hotspot' repository. Perhaps, such 
massive update is too late for JDK9 time frame and could be done only in 
JDK10.
So, if the changes depending on 8162727 are not so critical and could be 
deferred I would prefer to postpone this fix.

Thanks,
Dima


On 29.07.2016 4:29, Vladimir Kozlov wrote:
> It affects all groups. Should be reviewed on hotspot-dev.
>
> Thanks,
> Vladimir
>
> On 7/28/16 10:19 AM, Dmitrij Pochepko wrote:
>> Hi,
>>
>> please review small patch for 8162727 - Testbug: additional requires 
>> properties can't be used for filtering server vm in jdk jtreg tests
>>
>> A problem is that tests under jdk repo can't use additional jtreg 
>> requires properties(like vm.flavor to filter out client or server 
>> vm). The same functionality was introduced for hotspot repo as part
>> of JDK-8154956. So, in order to filter tests using these additional 
>> properties a small fix is created.
>>
>> webrev: http://cr.openjdk.java.net/~dpochepk/8162727/webrev.01/
>> CR: https://bugs.openjdk.java.net/browse/JDK-8162727
>>
>> Thanks,
>> Dmitrij