RFR: 8038332: The trace event vm/class/load is not always being sent

[Max Ockner]

Jiangli,
Thanks for looking.  I didn't see anything that looked like it might 
produce duplicate events. However, I did see some additional places 
where it looks like no event is fire.

Can anyone point me to the event specs?

Thanks,
Max

On 6/9/2016 4:39 PM, Jiangli Zhou wrote:
> Hi Max,
>
> Looks ok. The only possible issue is more than one event might be sent in some of the call paths. But my quick search didn’t find any of such case.
>
> Thanks,
> Jiangli
>
>> On Jun 9, 2016, at 11:05 AM, Max Ockner <max.ockner at oracle.com> wrote:
>>
>> Hello,
>>
>> Please review this small fix which causes the vm/class/load event to be fired from JVM_DefineClass() and JVM_DefineClassWithSource().
>>
>> Webrev: http://cr.openjdk.java.net/~mockner/8038332/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8038332
>>
>> The vm/class/load event  (EventClassLoad) was previously fired in 2 places:
>>
>> SystemDictionary::parse_stream
>> SystemDictionary::resolve_instance_class_or_null
>>
>> parse_stream is the standard option for creating a klass from a stream, but JVM_DefineClass uses a different function:
>>
>> SystemDictionary::resolve_from_stream.
>>
>> This did not fire a vm/class/load event. Now it does fire the event.
>>
>> Sanity tested with jtreg runtime. Issue was reproduced and tested using the reproducer script attached to the bug
>>
>> Thanks,
>> Max