[8u] request for approval: "8158260: PPC64: unaligned Unsafe.getInt can lead to the generation of illegal instructions"

[Rob McKenna]

On 22/06/16 04:34, Volker Simonis wrote:
> On Wed, Jun 22, 2016 at 4:07 PM, Rob McKenna <rob.mckenna at oracle.com> wrote:
> > Approved assuming the HS folks are ok with the test situation.
> >
> 
> Thanks Rob!
> Yes, let's wait for another HS review.
> 
> > I'm not sure I get the sponsor question. If you are an approved committer to jdk8u-dev (which you appear to be) you can push, otherwise you would need a sponsor.
> 
> As all hotspot changes have to go trough JPRT external committers are

JDK9 only :)

	-Rob

> not allowed to directly push to HS repos - expect for changes which
> only touch platforms which aren't built and tested by Oracle anyway
> (e.g. ppc64 and aarch64). My initial change contained a shared test so
> I needed a sponsor whereas the downport only touches a ppc64 file.
> 
> Regards,
> Volker
> 
> >
> >         -Rob
> >
> > On 22/06/16 11:35, Volker Simonis wrote:
> >> Hi,
> >>
> >> could you please approve the backport of the following ppc64-only fixe
> >> to jdk8u-dev:
> >>
> >> 8158260: PPC64: unaligned Unsafe.getInt can lead to the generation of
> >> illegal instructions
> >>
> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8158260
> >> Webrev: http://cr.openjdk.java.net/~simonis/webrevs/2016/8158260/
> >> Review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-June/023347.html
> >> URL: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/5f3687f2143c
> >>
> >> The original change has a JTreg test which uses the new
> >> jdk.internal.misc.Unsafe class and some of its features like
> >> Unsafe.unalignedAccess() which are not available in jdk8 so I propose
> >> to exclude the test from the downport.
> >>
> >> Without the test the change only touches a ppc64 specific file and
> >> applies cleanly to jdk8u-dev:
> >>
> >> http://cr.openjdk.java.net/~simonis/webrevs/2016/8158260_8u
> >>
> >> As this backport is now truly "ppc64-only", can I push it directly to
> >> jdk8u-dev/hotspot or do I still need a sponsor?
> >>
> >> Thank you and best regards,
> >> Volker