[8u] request for approval: "8158260: PPC64: unaligned Unsafe.getInt can lead to the generation of illegal instructions"

Volker Simonis volker.simonis at gmail.com
Thu Jun 23 08:41:23 UTC 2016


Thanks Vladimir!

Regards,
Volker


On Wed, Jun 22, 2016 at 9:08 PM, Vladimir Kozlov
<vladimir.kozlov at oracle.com> wrote:
> Changes looks good. I agree with exclusion of test.
>
> Since it is only ppc64 changes you can push it yourself.
>
> Note, we do run Hotspot changes through JPRT to push into 8u-dev.
>
> Thanks,
> Vladimir
>
>
> On 6/22/16 2:35 AM, Volker Simonis wrote:
>>
>> Hi,
>>
>> could you please approve the backport of the following ppc64-only fixe
>> to jdk8u-dev:
>>
>> 8158260: PPC64: unaligned Unsafe.getInt can lead to the generation of
>> illegal instructions
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8158260
>> Webrev: http://cr.openjdk.java.net/~simonis/webrevs/2016/8158260/
>> Review:
>> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-June/023347.html
>> URL: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/5f3687f2143c
>>
>> The original change has a JTreg test which uses the new
>> jdk.internal.misc.Unsafe class and some of its features like
>> Unsafe.unalignedAccess() which are not available in jdk8 so I propose
>> to exclude the test from the downport.
>>
>> Without the test the change only touches a ppc64 specific file and
>> applies cleanly to jdk8u-dev:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/2016/8158260_8u
>>
>> As this backport is now truly "ppc64-only", can I push it directly to
>> jdk8u-dev/hotspot or do I still need a sponsor?
>>
>> Thank you and best regards,
>> Volker
>>
>


More information about the hotspot-dev mailing list