RFD: C2 bug: 8157306 random infrequent null pointer exceptions in javac

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Jun 24 22:37:05 UTC 2016


Looks good. I submitted testing and will push if testing pass.

Thanks,
Vladimir

On 6/23/16 9:18 AM, Andrew Haley wrote:
> On 22/06/16 22:13, Vladimir Kozlov wrote:
>> Thank you, Andrew, for finding the cause of this problem.
>> Your fix looks good to me. Can you also add changes for the assert you mentioned - I think it is useful.
>> And, please, prepare webrev.
>
> http://cr.openjdk.java.net/~aph/8157306.1/
>
> There is no point putting an assert in call_catch_cleanup()
> immediately after we insert the precedence edges.  I think it is best
> to put the assert in verify_cfg(), where it makes the most sense.  I
> had to make verify_anti_dependences() const in order to call it from
> verify_cfg().  I hope this is OK.
>
> Thanks,
>
> Andrew.
>


More information about the hotspot-dev mailing list