Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Tue Jun 28 20:37:10 UTC 2016


On 6/28/16 13:11, serguei.spitsyn at oracle.com wrote:
> On 6/28/16 11:19, Daniel D. Daugherty wrote:
>> On 6/28/16 10:37 AM, serguei.spitsyn at oracle.com wrote:
>>> Hi Harold,
>>>
>>> Thank you again for the comments!
>>> This is the updated webrev:
>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.5/ 
>>>
>>
. . .
>>         Update: Yes, passing a non-NULL jobject as the class_loader 
>> parameter
>>             when the jobject does not refer to a "class loader" is 
>> caught
>>             at the upper layer.
>
> The upper layer does not check that it is a class loader, just for 
> non-NULL.

Sorry, I mistyped the above.
The upper layer does not check for the NULL which is correct as it is 
allowed.

Thanks,
Serguei


> I think, it is good to have an assert here to double-checks the 
> pre-conditions as other caller can be added later.
> But I'm Ok to get rid of it if you suggest.
>



More information about the hotspot-dev mailing list