RFR: 8078112: Integrate Selection/Resolution test suite into jtreg tests

[Dmitry Dmitriev]

Hello David,

Yes, you are right about the slowest machine. Thank you for the review!

Dmitry

On 02.03.2016 0:13, David Holmes wrote:
> On 2/03/2016 3:38 AM, Dmitry Dmitriev wrote:
>> Hello David,
>>
>> Thank you for the comments! I added build instructions to the tests.
>
> Thank you.
>
>> I specify timeout because on fastdebug builds test needs more time.
>
> Don't we set a different default timeout when running fastdebug? 
> Perhaps not. Anyway I see there are a range of different timeout 
> values specified so presumably this has been tuned for the slowest 
> machines ?
>
>> Only two tests will be run as part of JPRT submissions -
>> InvokeStaticSuccessTest and NoSuchMethodErrorTest.
>> InvokeStaticSuccessTest takes 1-3 seconds and NoSuchMethodErrorTest
>> takes 2-9 seconds. Other tests are excluded from JPRT run.
>
> Thanks - I misread the change to TEST.groups.
>
>> Updated webrev.01:
>> <http://cr.openjdk.java.net/%7Eddmitriev/8078112/webrev.01/>http://cr.openjdk.java.net/~ddmitriev/8078112/webrev.01/ 
>>
>
> I can't comment on the details of the tests themselves but the adding 
> of the test suite seems okay.
>
> Thanks,
> David
>
>> Thank you,
>> Dmitry
>>
>> On 01.03.2016 8:49, David Holmes wrote:
>>> Hi Dmitry,
>>>
>>> On 29/02/2016 9:27 PM, Dmitry Dmitriev wrote:
>>>> Hello,
>>>>
>>>> Please review this patch, which integrates the selection/resolution 
>>>> test
>>>> suite into the JTreg test suite. This test suite was developed by  
>>>> Eric
>>>> Mccorkle(OpenJDK: emc). Thanks Eric for that!
>>>>
>>>> This test suite uses a template-based generation scheme to exercise 
>>>> all
>>>> aspects of the updated selection/resolution test suite from JVMS 
>>>> 8.  It
>>>> runs a very large number of tests, representing a very wide variety of
>>>> cases.  Extensive javadoc comments are found throughout the test code
>>>> which describe the suite's functioning in more detail.
>>>>
>>>> Also note that this suite as already undergone extensive review as 
>>>> part
>>>> of the development process.
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8078112
>>>> webrev.00: http://cr.openjdk.java.net/~ddmitriev/8078112/webrev.00/
>>>> <http://cr.openjdk.java.net/%7Eddmitriev/8078112/webrev.00/>
>>>> Testing: Jprt, RBT(all platforms, product & fastdebug builds)
>>>
>>> I hate to open this debate again but I see:
>>>
>>>  @library /runtime/SelectionResolution/classes
>>>
>>> but no instructions on how to build the library contents.
>>>
>>> Do we really need to specify a timeout?
>>>
>>> @run main/othervm/timeout=300
>>>
>>> Will these tests now run as part of JPRT submissions? If so:
>>> a) have they been tested on all platforms?
>>> b) how long do they take to run?
>>>
>>> Thanks,
>>> David
>>>
>>>
>>>> Thanks,
>>>> Dmitry
>>