RFR(M): 8151156 - [TESTBUG] Integrate trivial Hotspot test changes from Jake before Jigsaw M3

Christian Tornqvist christian.tornqvist at oracle.com
Thu Mar 3 20:35:32 UTC 2016


Hi Harold,

I've updated the copyrights, thanks for the review!

Thanks,
Christian

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of
harold seigel
Sent: Thursday, March 3, 2016 8:52 AM
To: hotspot-dev at openjdk.java.net
Subject: Re: RFR(M): 8151156 - [TESTBUG] Integrate trivial Hotspot test
changes from Jake before Jigsaw M3

Hi Christian,

The changes look good.  Are there any copyrights that need to be updated?

Thanks, Harold

On 3/3/2016 7:37 AM, Christian Tornqvist wrote:
> Hi everyone,
>
>   
>
> Please review this change that integrates some of the trivial Hotspot
test
> changes made in Jake, these are all going into jdk9-dev in order to 
> make
it
> into master before M3 hits. There are three different kind of changes 
> included in this webrev:
>
>   
>
> -          Adding/correcting Module exports (using @module), this is a
no-op
> in JDK 9 until Jigsaw M3 gets in.
>
> -          @run driver -> @run main, jtreg has a bug where module
exports
> doesn't work correctly with driver
> (https://bugs.openjdk.java.net/browse/CODETOOLS-7901589)
>
> -          Two tests (test/serviceability/dcmd/gc/HeapDumpTest.java and
> test/serviceability/dcmd/gc/HeapDumpAllTest.java) had @build with a 
> misspelled package name, a new version of jtreg will treat this as an
error
>
>   
>
> Changes have been tested by running all of the Hotspot Jtreg tests.
>
>   
>
> Webrev:
>
> http://cr.openjdk.java.net/~ctornqvi/webrev/8151156/webrev.00/
>
>   
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8151156
>
>   
>
> Thanks,
>
> Christian
>
>   
>




More information about the hotspot-dev mailing list