RFR(M): 8151156 - [TESTBUG] Integrate trivial Hotspot test changes from Jake before Jigsaw M3

[David Holmes]

On 4/03/2016 2:40 PM, Christian Tornqvist wrote:
> Hi David,
>
> I've filed https://bugs.openjdk.java.net/browse/JDK-8151248 to deal with

Thanks.

> changing them back. As for nightly, I'd be surprised if they would fail,
> we'll handle them if they do.

Okay.

David

> Thanks,
> Christian
>
> -----Original Message-----
> From: David Holmes [mailto:david.holmes at oracle.com]
> Sent: Thursday, March 3, 2016 9:38 PM
> To: Christian Tornqvist <christian.tornqvist at oracle.com>; 'hotspot-dev
> developers' <hotspot-dev at openjdk.java.net>
> Subject: Re: RFR(M): 8151156 - [TESTBUG] Integrate trivial Hotspot test
> changes from Jake before Jigsaw M3
>
> Hi Christian,
>
> On 3/03/2016 10:37 PM, Christian Tornqvist wrote:
>> Hi everyone,
>>
>>
>>
>> Please review this change that integrates some of the trivial Hotspot
>> test changes made in Jake, these are all going into jdk9-dev in order
>> to make it into master before M3 hits. There are three different kind
>> of changes included in this webrev:
>>
>>
>>
>> -          Adding/correcting Module exports (using @module), this is a
> no-op
>> in JDK 9 until Jigsaw M3 gets in.
>>
>> -          @run driver -> @run main, jtreg has a bug where module exports
>> doesn't work correctly with driver
>> (https://bugs.openjdk.java.net/browse/CODETOOLS-7901589)
>
> Could this change have an adverse impact on the nightlies, now that
> unexpected/unwanted options will be passed through to the initial VM?
>
> Can you file a follow up bug to switch these all back to @driver once the
> jtreg problem is fixed.
>
> Thanks,
> David
>
>> -          Two tests (test/serviceability/dcmd/gc/HeapDumpTest.java and
>> test/serviceability/dcmd/gc/HeapDumpAllTest.java) had @build with a
>> misspelled package name, a new version of jtreg will treat this as an
>> error
>>
>>
>>
>> Changes have been tested by running all of the Hotspot Jtreg tests.
>>
>>
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~ctornqvi/webrev/8151156/webrev.00/
>>
>>
>>
>> Bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8151156
>>
>>
>>
>> Thanks,
>>
>> Christian
>>
>>
>>
>