RFR: 8151440: Move BitMap verfication inline functions out from bitMap.hpp

Stefan Karlsson stefan.karlsson at oracle.com
Wed Mar 9 11:38:53 UTC 2016


Thanks, Kim.

StefanK

On 2016-03-08 20:32, Kim Barrett wrote:
>> On Mar 8, 2016, at 6:15 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>>
>> This was intended to go to the hotspot-dev list. BCC:ing hotspot-gc-dev.
>>
>> Please reply to this mail to review this patch.
>>
>> StefanK
>>
>> On 2016-03-08 12:14, Stefan Karlsson wrote:
>>> Hi all,
>>>
>>> Please review to fix include problems with the bitMap files.
>>>
>>> http://cr.openjdk.java.net/~stefank/8151440/webrev.00/
>>> https://bugs.openjdk.java.net/browse/JDK-8151440
>>>
>>> Some verification code in bitMap.inline.hpp is used from bitMap.hpp. This adds a requirement that bitMap.inline.hpp always have to be included when bitMap.hpp is included, otherwise the compiler will complain.
>>>
>>> The patch fixes this by moving the verification/debugging code to the cpp file, and the move some inlined functions from bitMap.hpp to bitMap.inline.hpp.
>>>
>>> Thanks,
>>> StefanK
> Looks good.
>



More information about the hotspot-dev mailing list