RFR: 8151539: Remove duplicate AlwaysTrueClosures

Mikael Gerdin mikael.gerdin at oracle.com
Wed Mar 9 19:39:56 UTC 2016


Hi Stefan,

On 2016-03-09 17:44, Stefan Karlsson wrote:
> Hi all,
>
> Please review this patch to remove a bunch of redundant
> AlwaysTrueClosure classes.
>
> http://cr.openjdk.java.net/~stefank/8151539/webrev.00/

There is still
2128 // This should be moved to the shared markSweep code!
2129 class PSAlwaysTrueClosure: public BoolObjectClosure {
2130 public:
2131   bool do_object_b(oop p) { return true; }
2132 };
2133 static PSAlwaysTrueClosure always_true;
in psParallelCompact.cpp

Otherwise the change looks good, I don't need to see an updated webrev.

/Mikael

> https://bugs.openjdk.java.net/browse/JDK-8151539
>
> I've created an overloaded JNIHandles::weak_oops_do that uses its own
> AlwaysTrueClosure classes. This way callers of JNIHandles::weak_oops_do,
> that don't want to filter out any oops, can call the overloaded version
> without providing an instance of BoolObjectClosure.
>
> Thanks,
> StefanK


More information about the hotspot-dev mailing list