RFR: 8151539: Remove duplicate AlwaysTrueClosures

Stefan Karlsson stefan.karlsson at oracle.com
Wed Mar 9 20:36:08 UTC 2016


Thanks, Thomas.

StefanK

On 2016-03-09 21:26, Thomas Schatzl wrote:
> Hi,
>
> On Wed, 2016-03-09 at 21:01 +0100, Stefan Karlsson wrote:
>> Hi Mikael,
>>
>> On 2016-03-09 20:39, Mikael Gerdin wrote:
>>> Hi Stefan,
>>>
>>> On 2016-03-09 17:44, Stefan Karlsson wrote:
>>>> Hi all,
>>>>
>>>> Please review this patch to remove a bunch of redundant
>>>> AlwaysTrueClosure classes.
>>>>
>>>> http://cr.openjdk.java.net/~stefank/8151539/webrev.00/
>>> There is still
>>> 2128 // This should be moved to the shared markSweep code!
>>> 2129 class PSAlwaysTrueClosure: public BoolObjectClosure {
>>> 2130 public:
>>> 2131   bool do_object_b(oop p) { return true; }
>>> 2132 };
>>> 2133 static PSAlwaysTrueClosure always_true;
>>> in psParallelCompact.cpp
>>>
>>> Otherwise the change looks good, I don't need to see an updated
>>> webrev.
>> Great that you saw this!
>>
>> I've uploaded a new webrev, to make it easier for the second
>> reviewer:
>> http://cr.openjdk.java.net/~stefank/8151539/webrev.01/
>   looks good.
>
> Thomas
>



More information about the hotspot-dev mailing list