RFR: 8145235: Deprecate product flags that have been converted to Unified Logging
Rachel Protacio
rachel.protacio at oracle.com
Thu Mar 24 19:37:33 UTC 2016
Thanks for the review! And good point. It's to the 'arguments' tag to
follow the gc team's logging-deprecation precedent. Here's a new webrev
updating your non-product error messages to follow this scheme as well:
http://cr.openjdk.java.net/~rprotacio/8145235.01/
Builds and passes logging/RemovedDevelopFlagsTest.java.
Rachel
On 3/24/2016 10:56 AM, Max Ockner wrote:
> Rachel,
> This looks fine. Why are we logging this message to arguments tag?
> Should we be logging the non-product error messages to arguments as
> well?
> Thanks,
> Max
> On 3/22/2016 3:21 PM, Rachel Protacio wrote:
>> Hi,
>>
>> Please review this enhancement that prints a deprecation message for
>> the product flags we have aliased to UL options. We wanted to mimic
>> the GC deprecation messages as seen in arguments.cpp, e.g.
>>
>> log_warning(gc)("-XX:+PrintGCDetails is deprecated. Will use
>> -Xlog:gc* instead.");
>>
>> I have logged our deprecation messages to a new tag 'arguments' at
>> the 'warning' level (warning-level logging is always printed, without
>> having to be directly specified in the command line).
>>
>> Basic sample output:
>>
>> $ java -XX:+TraceMonitorInflation -version
>> [0.001s][warning][arguments] -XX:+TraceMonitorInflation is
>> deprecated. Will use -Xlog:monitorinflation=debug instead.
>> ...
>>
>> Sample output with "-"/"off" and multiple tags:
>>
>> $ java -XX:-TraceClassLoadingPreorder -version
>> [0.001s][warning][arguments] -XX:-TraceClassLoadingPreorder is
>> deprecated. Will use -Xlog:classload,preorder=off instead.
>> ...
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8145235
>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8145235/
>>
>> Tested locally for robustness w.r.t. multi-tag tagsets, multiple
>> aliased flags, etc.
>>
>> Thank you,
>> Rachel
>>
>
More information about the hotspot-dev
mailing list