RFR: 8152632: Rename LogHandle(...) to Log(...)

Kim Barrett kim.barrett at oracle.com
Tue Mar 29 23:11:48 UTC 2016


> On Mar 29, 2016, at 1:16 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
>> On Mar 29, 2016, at 9:43 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>> 
>> Hi all,
>> 
>> Please review this patch to rename the LogHandle macro to Log.
>> 
>> http://cr.openjdk.java.net/~stefank/8152632/webrev.01
>> https://bugs.openjdk.java.net/browse/JDK-8152632
>> 
>> The main motivation for this patch is to reuse the LogHandle name for a type-erased handle to a log instance (JDK-8152711).
> 
> If the sole motivation for this change is JDK-8152711, then I think we
> should not make this change.  I disagree with the current proposal for
> addressing JDK-8152711; I think there is a better alternative for that
> which doesn't need the change proposed by this RFR.
> 
> If there is some other motivation, I'd be willing to consider this
> change on that basis.

Stefan and I have talked about this offline, and he has convinced me that
even with a different change for JDK-8152711, there will still be reason to
make this change.  So I withdraw my objection to this renaming.



More information about the hotspot-dev mailing list