RFR(XS): 8154942 Remove ProcessTools.getVmInputArguments() from the hotspot test library, as it is not used by any of the hotspot tests

Christian Tornqvist christian.tornqvist at oracle.com
Thu May 5 16:20:34 UTC 2016


Hi George,

Yes, I agree that the cleanup should be done as a separate change. Change looks good.

Thanks,
Christian

-----Original Message-----
From: George Triantafillou [mailto:george.triantafillou at oracle.com] 
Sent: Tuesday, May 3, 2016 3:45 PM
To: Christian Tornqvist <christian.tornqvist at oracle.com>; hotspot-dev at openjdk.java.net
Subject: Re: RFR(XS): 8154942 Remove ProcessTools.getVmInputArguments() from the hotspot test library, as it is not used by any of the hotspot tests

Hi Christian,

As we discussed offline, there is definitely room for cleanup, but that warrants a separate RFE due to the extent of the changes required.

So, is this minor fix ready to commit?

-George

On 4/27/2016 11:44 AM, Christian Tornqvist wrote:
> Hi George,
>
> Are there any unnecessary @module tags we can remove as a result of this?
>
> Thanks,
> Christian
>
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On 
> Behalf Of George Triantafillou
> Sent: Wednesday, April 27, 2016 10:39 AM
> To: hotspot-dev at openjdk.java.net
> Subject: RFR(XS): 8154942 Remove ProcessTools.getVmInputArguments() 
> from the hotspot test library, as it is not used by any of the hotspot 
> tests
>
> Please review this very small change that removes the unused method
> getVmInputArguments() from ProcessTools.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8154942
> Webrev:
> http://cr.openjdk.java.net/~gtriantafill/bug-8154942/bug_8154942.patch
> /webrev/ 
> <http://cr.openjdk.java.net/%7Egtriantafill/bug-8154942/bug_8154942.pa
> tch/webrev/>
>
> Thanks,
> George
>




More information about the hotspot-dev mailing list