RFR (XS): rev3 8152856: Xcode 7.3 -Wshift-negative-value compile failure on Mac OS X
Gerard Ziemski
gerard.ziemski at oracle.com
Mon May 9 14:46:31 UTC 2016
PING
Can I ask for a second review please?
cheers
> On May 4, 2016, at 11:20 AM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
>
> Looks good.
>
> Best regards,
> Vladimir Ivanov
>
> On 5/4/16 7:02 PM, Gerard Ziemski wrote:
>> PING
>>
>> Can I please have a review of this small fix? I have removed makefile change, which is no longer needed, so this should be non-controversial to review:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8152856
>> webrev: http://cr.openjdk.java.net/~gziemski/8152856_rev3
>>
>>
>> cheers
>>
>>> On Apr 6, 2016, at 11:35 AM, Gerard Ziemski <gerard.ziemski at oracle.com> wrote:
>>>
>>> hi all,
>>>
>>> I have implemented and tested out the new proposed fix using constant instead of casts. Please review this new fix:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8152856
>>> webrev: http://cr.openjdk.java.net/~gziemski/8152856_rev2
>>>
>>> Passes JPRT hotspot and RBT hotspot/test/:hotspot_runtime
>>>
>>>
>>> cheers
>>>
>>>> On Mar 31, 2016, at 9:08 AM, Gerard Ziemski <gerard.ziemski at oracle.com> wrote:
>>>>
>>>> hi all,
>>>>
>>>> Since no-one has reviewed this yet and in the meantime we changed https://wiki.openjdk.java.net/display/HotSpot/StyleGuide to discourage using enums in hotspot (see JDK-8153116 for more details) I’m going to withdraw this proposed fix and try doing it by replacing enums with constant literals instead of using casts on enums.
>>>>
>>>> I therefore withdraw this fix for now.
>>>>
>>>>
>>>> cheers
>>>>
>>>>> On Mar 29, 2016, at 4:30 PM, Gerard Ziemski <gerard.ziemski at oracle.com> wrote:
>>>>>
>>>>> hi all,
>>>>>
>>>>> Please review this small fix that enables Xcde 7.3 support for building hotspot, which involved 2 things:
>>>>>
>>>>> - modify gcc.make to add support for 7.3 version of clang compiler
>>>>> - modify src/cpu/x86/vm/stubGenerator_x86_64.cpp, src/share/vm/oops/klass.hpp and src/share/vm/opto/library_call.cpp to cast 4 instances of signed int to unsigned when using shift operator to avoid "-Wshift-negative-value" warning.
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8152856
>>>>> http://cr.openjdk.java.net/~gziemski/8152856_rev1
>>>>>
>>>>> Passes JPRT hotspot on all platforms
>>>>>
>>>>
>>>
>>
More information about the hotspot-dev
mailing list