RFR(S) : 8156681 : Add jtreg wrapper for hotspot gtest tests

Igor Ignatyev igor.ignatyev at oracle.com
Thu May 12 15:30:38 UTC 2016


Jesper,

1st of all, thank you for review.

unfortunately, testing in our infra reveled some problems w/ the wrapper:
 - gtest test library can be located right in ‘test.nativepath’ or in ‘test.nativepath’/../../gtest
 - the wrapper pass all flags to gtestLauncher including flags which are not JVM flags, gtestLauncher pass all these args to JNI_CreateJavaVM, so we fail w/ 'Unrecognized option'

I have updated the webrev : http://cr.openjdk.java.net/~iignatyev/8156681/webrev.01/

could you please review the updated version?

Thanks,
— Igor 
 
> On May 10, 2016, at 8:32 PM, Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com> wrote:
> 
> Looks good!
> /Jesper
> 
> Den 10/5/16 kl. 18:31, skrev Igor Ignatyev:
>> http://cr.openjdk.java.net/~iignatyev/8156681/webrev.00/
>>> 71 lines changed: 71 ins; 0 del; 0 mod;
>> 
>> Hi all,
>> 
>> could you please integrate this small fix which adds a jtreg wrapper to run gtest tests?
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8156681
>> webrev: http://cr.openjdk.java.net/~iignatyev/8156681/webrev.00/
>> 
>> Thanks,
>> — Igor
>> 



More information about the hotspot-dev mailing list