RFR(XS): 8169625: Libjsig build doesn't set flags for ppc64/s390 builds
volker.simonis at gmail.com
Mon Nov 14 10:15:09 UTC 2016
Thanks a lot Erik!
On Mon, Nov 14, 2016 at 11:14 AM, Erik Joelsson
<erik.joelsson at oracle.com> wrote:
> Looks good. I will push it.
> On 2016-11-14 11:09, Volker Simonis wrote:
>> can I please have a review and sponsor for the following small change
>> which only affects ppc64/s390x but touches a shared make file:
>> It is unfortunate that the build of the libjsig library (see
>> make/lib/CompileLibjsig.gmk) doesn't reuse the generic compiler flags
>> used by the hotspot build (i.e. the ones specified in JVM_CFLAGS).
>> Instead, CompileLibjsig.gmk defines its own compiler flags in
>> LIBJSIG_CPU_FLAGS but not for ppc64 and s390x. This leads to problems
>> if the compiler on these platforms uses other default settings as
>> configured for the OpenJDK build.
>> Thank you and best regards,
More information about the hotspot-dev