RFR: 8170100: AArch64: Crash in C1-compiled code accessing References

[Andrew Dinn]

On 21/11/16 15:18, Andrew Haley wrote:
> In the entry of
> TemplateInterpreterGenerator::generate_Reference_get_entry the
> sender's SP is saved in r13, a call-clobbered register. We need to
> save it in a register which is not call-clobbered when we call
> g1_write_barrier_pre().
> 
> It would be better to convert all usages of r13 as senderSP to r19,
> but this is less risky.  I'll do it in JDK 10.
> 
> http://cr.openjdk.java.net/~aph/8170100/

Looks good to me (not an official review). I agree that postponing the
full change to JDK10 is a wiser.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander