RFR(XXS) : 8170228 : register closed @requires property setter

Igor Ignatyev igor.ignatyev at oracle.com
Thu Nov 24 12:14:31 UTC 2016


Dima,

thanks for review.
I’ve added more detail to the bug report. I hope it’ll be enough for descendants to understand why it was needed.

Thanks,
— Igor

> On Nov 23, 2016, at 4:24 PM, Dmitry Fazunenenko <dmitry.fazunenko at oracle.com> wrote:
> 
> Hi Igor,
> 
> The change itself looks good to me.
> 
> Would you provide a bit more information into the CR.
> "register closed @requires property setter" doesn't provide enough information to understand the reasons why it's necessary.
> 
> Thanks,
> Dima
> 
> On 23.11.2016 15:46, Igor Ignatyev wrote:
>> Hi all,
>> 
>> could you please review the changeset which registers closed vm property setter (for @requires expressions)?
>> this setter is register as optional, so test execution won’t fail if the file doesn’t exist.
>> 
>> webrev.top : http://cr.openjdk.java.net/~iignatyev/8170228/top/webrev.00/
>> webrev.hotspot : http://cr.openjdk.java.net/~iignatyev/8170228/hotspot/webrev.00/
>> JBS : https://bugs.openjdk.java.net/browse/JDK-8170228
>> 
>> Thanks,
>> — Igor
> 



More information about the hotspot-dev mailing list