RFR(S) : 8166129 : hitting vmassert during gtest execution doesn't generate core and hs_err files

[Kim Barrett]

> On Sep 30, 2016, at 12:06 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~iignatyev/8166129/webrev.00/
>> 54 lines changed: 31 ins; 14 del; 9 mod;
> 
> Hi all,
> 
> could you please review the patch which enables core dumping and hs_err file generation in case of vmassert, guarantee and the like are hit during gtest tests execution?
> 
> before this fix, we always initialize a jvm w/ -XX:+SuppressFatalErrorMessage and -XX:-CreateCoredumpOnCrash, now we do so only if we run assert tests, tests which we expect to hit an vmassert. 
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8166129
> webrev: http://cr.openjdk.java.net/~iignatyev/8166129/webrev.00/
> 
> Thanks,
> — Igor

Does this change eliminate the need for this (IMO misplaced) bit of code in the vmassert macro?

    if (is_executing_unit_tests()) {                                           \
      report_assert_msg(__VA_ARGS__);                                          \
    }                                                                          \