RFR(S) : 8166129 : hitting vmassert during gtest execution doesn't generate core and hs_err files

Kim Barrett kim.barrett at oracle.com
Tue Oct 4 02:22:49 UTC 2016


> On Oct 3, 2016, at 4:33 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> Kim,
> 
>> Does this change eliminate the need for this (IMO misplaced) bit of code in the vmassert macro?
> unfortunately not, since we still disable fatal error reporting for assert tests, we need to have that code to support TEST_VM_ASSERT_MSG tests — assert tests which check that expected assert message is printed out. I agree that bit of code does not really look nice, but I’d prefer to work on that issue separately.

Thanks for the explanation.  Is there a CR for that?

As for this change for 8166129, looks good.




More information about the hotspot-dev mailing list